STY: change some absolute imports to relative imports. #67
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Those modules are the minimal set needed to bundled the parts we care about for grits support in enstaller.
Upstream is at requests 2.0.1, and we have 1.2.3 in our repo, so I don't think we need to care about 0.* anymore. This allows encore not to depend on requests anymore.
Member
|
@corranwebster we should probably get this in, no? |
Contributor
|
If it is still relevant. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Those modules are the minimal set needed to bundled the parts we care about for grits support in enstaller. I also removed the check on requests, so that encore does not need to import requests anymore. I've figured we don't care about requests < 1.0.0 anymore (we could enforce this in the setup.py, but I saw an empty install_requires).
@corran or @sjagoe: can you look at this ?