Replace use of deprecated HasTraits.set method with HasTraits.trait_set.#118
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #118 +/- ##
=======================================
Coverage 36.26% 36.26%
=======================================
Files 199 199
Lines 6278 6278
Branches 698 698
=======================================
Hits 2277 2277
Misses 3926 3926
Partials 75 75
Continue to review full report at Codecov.
|
Member
Author
|
@rkern Quick review? I hope this is an easy one. |
Member
Author
|
@corranwebster says LGTM. Merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix a single use of the deprecated
HasTraits.setmethod. This was causingDeprecationWarnings in the test suite of another project.I did a quick search for other uses of
HasTraits.getandHasTraits.set, but didn't spot any.