Replace "depends_on" in "Property" traits with "observe"#400
Merged
Conversation
modified: envisage/examples/demo/plugins/tasks/attractors/model/henon.py modified: envisage/examples/demo/plugins/tasks/attractors/model/i_model_3d.py modified: envisage/examples/demo/plugins/tasks/attractors/model/lorenz.py modified: envisage/examples/demo/plugins/tasks/attractors/model/rossler.py modified: envisage/examples/demo/plugins/tasks/attractors/model_help_pane.py modified: envisage/examples/demo/plugins/tasks/attractors/plot_2d_pane.py modified: envisage/plugins/python_shell/view/namespace_view.py modified: envisage/ui/tasks/action/task_window_toggle_group.py modified: envisage/ui/tasks/task_window.py modified: examples/legacy/plugins/tasks/ipython_kernel/example_task.py modified: examples/legacy/plugins/tasks/ipython_kernel/python_editor.py
aaronayres35
approved these changes
Apr 16, 2021
Contributor
aaronayres35
left a comment
aaronayres35
left a comment
There was a problem hiding this comment.
Changes LGTM
I tested the attractors example as well and generally things seemed okay.
However, if I change the initial_point of any of the models I get an error in the traceback. I checked and the same thing was occurring on master, so it is through no fault of this PR.
Contributor
Author
|
created #404 for the attractors example issue |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR replaces the
depends_oninPropertytraits withobserveinstead. I tested that the attractors example still works as expected.