Revert PR #354#422
Merged
Merged
Conversation
added 2 commits
June 11, 2021 18:10
extension point items. The test now uses a static trait change handler like before modified: envisage/tests/test_plugin.py
Closed
Contributor
Author
|
@mdickinson i opened this PR given our earlier discussion. |
aaronayres35
approved these changes
Jun 11, 2021
Contributor
There was a problem hiding this comment.
LGTM
although I haven't yet tested #421 with these changes yet EDIT: done, the test passes with these changes 🎉
rahulporuri
pushed a commit
that referenced
this pull request
Jun 17, 2021
* Revert "Support observe("name:items") for ExtensionPoint [Requires Traits 6.1] (#354)"
This reverts commit d62af08.
* TST/FIX : Revert test that used observe to listen to changes to
extension point items. The test now uses a static trait change handler
like before
modified: envisage/tests/test_plugin.py
rahulporuri
pushed a commit
that referenced
this pull request
Jun 17, 2021
* Revert PR #354 (#422) * Revert "Support observe("name:items") for ExtensionPoint [Requires Traits 6.1] (#354)" This reverts commit d62af08. * TST/FIX : Revert test that used observe to listen to changes to extension point items. The test now uses a static trait change handler like before modified: envisage/tests/test_plugin.py * Regression test for #417 (#421) * Add failing test * STY: Fix line spacing issues Co-authored-by: Poruri Sai Rahul <rporuri@enthought.com> * Fix test suite dependence on ipykernel (#423) * Fix hard test suite dependence on ipykernel * Update envisage/tests/test_ids.py Co-authored-by: Poruri Sai Rahul <rporuri@enthought.com> Co-authored-by: Poruri Sai Rahul <rporuri@enthought.com> * DOC : Update changelog modified: CHANGES.rst Co-authored-by: Mark Dickinson <mdickinson@enthought.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR reverts PR #354 from the
masterbranch. This PR seems to be the cause of the issue #417 which is why we are reverting it, until we can investigate the issue and find a solution.This PR also undoes a change to the plugin test case made in PR #401. Because we cannot use
observeto listen to changes in an extension point anymore, the conversion from_*_changedtoobserveneeded to be undone.This PR replaces #418 which only tries to revert PR #354 on the maintenance branch. We prefer this PR over #418 because we don't want the
masterbranch to be in a broken state.