Skip to content

Test on Python 3.7 and 3.8, and update classifiers for Python 3.8#8

Merged
mdickinson merged 5 commits into
masterfrom
support-python-38
Feb 3, 2020
Merged

Test on Python 3.7 and 3.8, and update classifiers for Python 3.8#8
mdickinson merged 5 commits into
masterfrom
support-python-38

Conversation

@mdickinson
Copy link
Copy Markdown
Member

@mdickinson mdickinson commented Jan 20, 2020 •
edited
Loading

Run Travis CI tests on Python 3.7 and 3.8, and update classifiers to make it clear 3.8 is supported.

EDIT: Also changes the way that the NumPy version is selected. See discussion in #10.

Closes #9.

@mdickinson
Copy link
Copy Markdown
Member Author

mdickinson commented Jan 20, 2020

NumPy issues on 3.5 and 3.7 on Linux (but fine on 3.6 and 3.8). Permissions issues on Windows.

@mdickinson
Copy link
Copy Markdown
Member Author

mdickinson commented Jan 20, 2020

The NumPy versions differ for the various Travis CI builds; looks like we have a problem with NumPy 1.15.4.

  • Python 2.7: NumPy 1.16.2
  • Python 3.5: NumPy 1.15.4
  • Python 3.6: NumPy 1.16.2
  • Python 3.7: NumPy 1.15.4
  • Python 3.8: NumPy 1.17.2

@mdickinson
Copy link
Copy Markdown
Member Author

mdickinson commented Jan 20, 2020

PR is on hold until appveyor permissions can be fixed (waiting on internal IT request).

@mdickinson mdickinson changed the title Test on Python 3.7 and 3.8, and update classifiers for Python 3.8 [On hold] Test on Python 3.7 and 3.8, and update classifiers for Python 3.8 Jan 20, 2020
This was referenced Jan 20, 2020
Closed
Closed
@mdickinson mdickinson closed this Feb 3, 2020
@mdickinson mdickinson reopened this Feb 3, 2020
@mdickinson mdickinson closed this Feb 3, 2020
@mdickinson mdickinson reopened this Feb 3, 2020
@mdickinson mdickinson closed this Feb 3, 2020
@mdickinson mdickinson reopened this Feb 3, 2020
@mdickinson mdickinson changed the title [On hold] Test on Python 3.7 and 3.8, and update classifiers for Python 3.8 Test on Python 3.7 and 3.8, and update classifiers for Python 3.8 Feb 3, 2020
@mdickinson
Copy link
Copy Markdown
Member Author

mdickinson commented Feb 3, 2020

Appveyor is now working, and passing.

@mdickinson
Copy link
Copy Markdown
Member Author

mdickinson commented Feb 3, 2020

@rahulporuri Would you be willing to review? (Not at all urgent.)

@mdickinson mdickinson merged commit cdb90e7 into master Feb 3, 2020
@mdickinson mdickinson deleted the support-python-38 branch February 3, 2020 15:43
@mdickinson mdickinson mentioned this pull request Oct 7, 2020
Closed
@mdickinson mdickinson mentioned this pull request Jun 11, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@rahulporuri rahulporuri rahulporuri approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

ImportError failure with NumPy 1.15.4

2 participants

@mdickinson @rahulporuri