pkg_resources is deprecated in favor of importlib.resources#1322
Merged
prabhuramachandran merged 1 commit intoDec 20, 2024
Conversation
prabhuramachandran
requested changes
Dec 17, 2024
Member
There was a problem hiding this comment.
Many thanks for this, this conflicts with the recent changes from #1315, could you please update this and I can merge the fix? Thank you.
mr-c
force-pushed
the
pkg_resources-deprecated
branch
from
a19e07d to
614b5ab
Compare
Contributor
Author
|
Thank you @prabhuramachandran ; I rebased the PR |
prabhuramachandran
approved these changes
Dec 19, 2024
Member
prabhuramachandran
left a comment
prabhuramachandran
left a comment
There was a problem hiding this comment.
Looks fine except I am unable to keep track of the changes between Python versions and our minimum requirement.
Member
|
@mr-c -- could you please rebase this so we can run the checks. |
mr-c
force-pushed
the
pkg_resources-deprecated
branch
from
614b5ab to
33a2a3f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.