Avoid ndarray comparisons with None.#146
Merged
Merged
Conversation
These avoid doing implicit comparisons of arrays with `None`.
Member
|
LGTM. I can't reproduce the Travis CI failure locally, either on this branch or on master. |
Member
|
(and it's the same failure as in #138; clearly unrelated). |
Member
Author
|
Yeah, it's been failing on that test for the past month. https://travis-ci.org/enthought/mayavi/builds I'll take the LGTM for both PRs. |
rkern
added a commit
that referenced
this pull request
Sep 24, 2014
Avoid ndarray comparisons with None.
Contributor
Thank you Robert! |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In future versions of numpy, this will not return
Falseas it currently does.Fixes #144