Skip to content

Toolkit specific code in seemingly agnostic modules. #957

@aaronayres35

Description

@aaronayres35

This was motivated by #954 (comment)

Basically, the module pyface/dock/dock_sizer.py, given that there is no wx along its path, appears like it would be toolkit agnostic.
Similarly in pyface/sizers/. However, these modules directly do import wx.

We should audit the codebase for such occurrences. I believe in an idea world we would have these modules have a ___ = toolkit_object("_____") and then some separate module eg pyface/ui/wx/dock/dock_sizer.py containing the wx specific code. (I would think this is true even if there is no qt analogue for these sorts of things, but perhaps

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions