Skip to content

Bleeding edge cron job#112

Merged
aaronayres35 merged 7 commits into
masterfrom
bleeding-edge-cron
Jun 24, 2021
Merged

Bleeding edge cron job#112
aaronayres35 merged 7 commits into
masterfrom
bleeding-edge-cron

Conversation

@aaronayres35
Copy link
Copy Markdown
Contributor

This PR adds a "bleeding edge" cron job following the suggestion of this comment:
#111 (comment)

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Jun 24, 2021

Codecov Report

Merging #112 (fba49e2) into master (7234f21) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #112   +/-   ##
=======================================
  Coverage   65.71%   65.71%           
=======================================
  Files          60       60           
  Lines        2870     2870           
  Branches      369      369           
=======================================
  Hits         1886     1886           
  Misses        892      892           
  Partials       92       92           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7234f21...fba49e2. Read the comment docs.

Copy link
Copy Markdown
Contributor

@rahulporuri rahulporuri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM

Comment thread .github/workflows/bleeding-edge.yml Outdated
Comment thread .github/workflows/bleeding-edge.yml Outdated
Comment on lines +42 to +43
edm run -e bootstrap -- python -m pip install --force-reinstall "git+http://github.com/enthought/traits.git#egg=traits"
edm run -e bootstrap -- python -m pip install --force-reinstall scipy
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did not add --no-deps based on a comment I saw in envisage etstool:

# Without the --no-dependencies flag such that new dependencies on
# master are brought in.

Also I also used --force-reinstall.

Effectively I saw this PR enthought/chaco#544 and followed. This may not be necessary though. AFAIK traits has no required dependencies anyway, but scipy does

@aaronayres35 aaronayres35 merged commit 4b46e16 into master Jun 24, 2021
@aaronayres35 aaronayres35 deleted the bleeding-edge-cron branch June 24, 2021 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants