MAINT: fix unit conversion#174
Merged
Merged
Conversation
mdickinson
reviewed
Mar 22, 2023
| self.assertAlmostEqual(30., q1.data, 1, | ||
| "Propagation test expected data 30, got %s" % str(q1.data)) | ||
|
|
||
| def test_propagation2(self): |
Member
There was a problem hiding this comment.
Nitpick: let's use a better test method name here. How about something like test_propagation_to_imperial?
Contributor
Author
There was a problem hiding this comment.
Sure, just changed
mdickinson
approved these changes
Mar 22, 2023
Member
mdickinson
left a comment
mdickinson
left a comment
There was a problem hiding this comment.
LGTM, modulo one nitpick about a test method name.
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The original unit conversion done in propagate_data_changes (scimath.units.quantity) can cause conversion error. This PR adds a fix and test for that. closes issue #171