Maint: Avoid calling observe's dispatch with named arguments#1065
Merged
Conversation
kitchoi
changed the title
corranwebster
approved these changes
May 7, 2020
Contributor
corranwebster
left a comment
corranwebster
left a comment
There was a problem hiding this comment.
This is a good change.
19 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #977
This PR removes the requirement on the event argument name for the dispatch callable, as the requirement unnecessarily forbids the use of other generic dispatch-like functions, such as
concurrent.futures.Executor.submit(callable, *args, **kwargs). With this, it will be possible to use something likeExecutor.submitas the dispatch callable.(Whether to expose this flexibility to the user API is a separate discussion though.)
Checklist
Update API reference (docs/source/traits_api_reference)Update User manual (docs/source/traits_user_manual)Update type annotation hints intraits-stubs