Cython port: Switch use of HasTraits.set to HasTraits.trait_set in tests#124
Closed
sjagoe wants to merge 2 commits into
Closed
Cython port: Switch use of HasTraits.set to HasTraits.trait_set in tests#124sjagoe wants to merge 2 commits into
sjagoe wants to merge 2 commits into
Conversation
Member
|
LGTM. |
Member
|
👍 |
Member
|
@sjagoe: Is this PR still relevant? Should it be either closed or merged? |
Contributor
Author
|
@mdickinson It is still relevant, I believe. Note that it is not to master, but to the cython port branch (hence the tests not passing). |
Member
|
Can it be merged then, or does it need additional review? |
Member
|
We can retarget it to master, I think. |
Contributor
Author
|
@rkern I'll create a new PR against master. |
jvkersch
pushed a commit
that referenced
this pull request
May 22, 2016
PR #124 switched the use of the deprecated .set method to .trait_set, since the former is not defined on the Cython side. However, a later commit undid that change, causing the tests to fail.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.