Fix list listener parsing#195
Merged
Merged
Conversation
Do not require a list member listener to be the final name parameter
|
Can one of the admins verify this patch? |
Member
|
@noraderam can you add a test replicating the original issue? |
Contributor
Author
|
Sure, I've added a regression test. |
Member
|
@noraderam thanks! Last thing is adding a line in the changelog |
Member
|
LGTM. The changelog needs some cleaning up at some point - at the moment it doesn't seem to be able to decide whether it's pretending to be Markdown or reST. That's for another PR, though. |
Contributor
Author
|
@dpinte Do you have anything else on this? |
Member
|
Merging. Thanks for the fix! |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make it possible to define list listeners that are not at the end of a
listener group.
Currently, a listener on a list trait 'b[]' must be the last element defined in a list
of listeners--e.g. c = Property(depends_on=['a', 'b[]']). Putting the list
listener first (depends_on=['b[]', 'a']) causes an exception:
"TraitError: Expected '[]' at the end of an item at column 4 of 'b[],a'"
This issue also makes it impossible to listen to multiple lists.