Skip to content

Add new "ArrayOrNone" Trait type.#219

Merged
mdickinson merged 9 commits into
masterfrom
feature/array-or-none
Dec 18, 2014
Merged

Add new "ArrayOrNone" Trait type.#219
mdickinson merged 9 commits into
masterfrom
feature/array-or-none

Conversation

@mdickinson
Copy link
Copy Markdown
Member

Resolves #218.

@mdickinson mdickinson mentioned this pull request Dec 17, 2014
4 tasks
@coveralls
Copy link
Copy Markdown

Coverage Status

Coverage increased (+0.42%) when pulling c06e57e on feature/array-or-none into 751603b on master.

@rkern
Copy link
Copy Markdown
Member

rkern commented Dec 17, 2014

LGTM! Thanks!

@coveralls
Copy link
Copy Markdown

Coverage Status

Coverage increased (+0.42%) when pulling fc290c7 on feature/array-or-none into 751603b on master.

Comment thread traits/trait_numeric.py Outdated
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@corranwebster pointed out that this class mixes old-style and new-style; it should be consistent.

Comment thread traits/tests/test_array_or_none.py Outdated
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

List and on_trait_change aren't used here.

@coveralls
Copy link
Copy Markdown

Coverage Status

Coverage increased (+0.42%) when pulling 7829647 on feature/array-or-none into 751603b on master.

@coveralls
Copy link
Copy Markdown

Coverage Status

Coverage increased (+0.42%) when pulling c9e3666 on feature/array-or-none into 751603b on master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add ArrayOrNone trait.

3 participants