Avoid containment-related DeprecationWarning on Python 3.7#855
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #855 +/- ##
=========================================
Coverage ? 72.44%
=========================================
Files ? 51
Lines ? 6369
Branches ? 1277
=========================================
Hits ? 4614
Misses ? 1361
Partials ? 394
Continue to review full report at Codecov.
|
mdickinson
commented
Jan 29, 2020
corranwebster
approved these changes
Jan 30, 2020
mdickinson
added a commit
that referenced
this pull request
Jan 30, 2020
* Avoid containment-related DeprecationWarning on Python 3.7 * Fix a test (cherry picked from commit cdd31e5)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also adds some unit tests for
safe_contains.Fixes #853