-
Notifications
You must be signed in to change notification settings - Fork 99
Remove imports from traitsui.editors.__init__ #1759
Copy link
Copy link
Open
Labels
component: coreIssues related to the core functionality, ui composition and life cycle.Issues related to the core functionality, ui composition and life cycle.difficulty: easyIssues which don't need much/any context about the package.Issues which don't need much/any context about the package.type: cleanupIssues related to clean up _excluding_ refactoringIssues related to clean up _excluding_ refactoring
Milestone
Metadata
Metadata
Assignees
Labels
component: coreIssues related to the core functionality, ui composition and life cycle.Issues related to the core functionality, ui composition and life cycle.difficulty: easyIssues which don't need much/any context about the package.Issues which don't need much/any context about the package.type: cleanupIssues related to clean up _excluding_ refactoringIssues related to clean up _excluding_ refactoring
A long time ago, all editor factories were imported directly from
traitsui.editors. Over a decade ago, thetraitsui.editors.apimodule was added, but import fromtraitsui.editorswas still kept for backwards compatibility.However this causes problems with circular imports in a number of places (eg. see discussion here:
traitsui/traitsui/null/rgb_color_trait.py
Lines 145 to 151 in 9f4acb8
We should remove the imports from
traitsui.editors.__init__and fix situations where we are working around circular imports.This would technically be a breaking change, but the impact is like very low at this point.