Skip to content

Update changelog#1611

Merged
aaronayres35 merged 10 commits into
masterfrom
update-changelog
May 6, 2021
Merged

Update changelog#1611
aaronayres35 merged 10 commits into
masterfrom
update-changelog

Conversation

@aaronayres35
Copy link
Copy Markdown
Contributor

@aaronayres35 aaronayres35 commented Apr 26, 2021

This PR starts the process of updating the changelog in advance of the upcoming 7.2.0 release

It also pulls in the news fragment system previously introduced in apptools (see enthought/apptools#181) to make the process of updating the changelog more efficient in future releases.

@rahulporuri
Copy link
Copy Markdown
Contributor

@aaronayres35 looks like the only thing remaining on this PR are the detailed notes and highlights?

@rahulporuri rahulporuri self-requested a review May 3, 2021 05:24
Comment thread CHANGES.txt
complete list, see PRs in the "Removals" section below. These were all
generally unused / deprecated for sometime. Also, importing directly from
``traitsui.editors`` has been deprecated. Please update imports to import
directly from :mod:`traitsui.api` or :mod:`traitsui.editors.api`.
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Which should we be recommending here? I listed both currently, but I imagine we just want people to import from traitsui.api?
This has been discussed before

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This has been discussed before

I dont remember that discussion - or the conclusion of that discussion.
I'm fine with listing both. I completely forgot about the fact that the editor factories are also importable via traitsui.api. I think we can leave it up to the users to choose. I don't think we'll remove traitsui.editors.api.

@aaronayres35 aaronayres35 changed the title [WIP] Update changelog Update changelog May 5, 2021
Copy link
Copy Markdown
Contributor

@rahulporuri rahulporuri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aaronayres35 aaronayres35 merged commit f7fa4b4 into master May 6, 2021
@aaronayres35 aaronayres35 deleted the update-changelog branch May 6, 2021 13:38
@aaronayres35 aaronayres35 mentioned this pull request May 6, 2021
28 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants