Skip to content

Call HasPrivateTraits.__init__() in GroupEditor.__init__ #1674

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aaronayres35 merged 5 commits into from
Jun 21, 2021
+6 −1
Merged

Call HasPrivateTraits.__init__() in GroupEditor.__init__ #1674

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
61d74d3
call HasPrivateTraits.__init__() in GroupEditor.__init__
aaronayres35 May 19, 2021
94428bc
alphabetize imports
aaronayres35 May 19, 2021
7a817dc
alphabetize imports (for real this time)
aaronayres35 May 19, 2021
e72258f
add comment on why we call HasPrivateTraits.__init__
aaronayres35 Jun 21, 2021
64849e9
add changelog entry
aaronayres35 Jun 21, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions docs/releases/upcoming/1674.bugfix.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Call HasPrivateTraits.__init__() in GroupEditor.__init__ (#1674)
6 changes: 5 additions & 1 deletion traitsui/qt4/ui_panel.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@

from pyface.qt import QtCore, QtGui

from traits.api import Any, Instance, Undefined
from traits.api import Any, HasPrivateTraits, Instance, Undefined
from traits.observation.api import match

from traitsui.api import Group
Expand Down Expand Up @@ -1259,6 +1259,10 @@ class GroupEditor(Editor):
def __init__(self, **traits):
""" Initialise the object.
"""
# We intentionally don't want to call Editor.__init__ here as
# GroupEditor does its own thing. However, we still want Traits
# machinery to be set up properly.
HasPrivateTraits.__init__(self, **traits)
Comment thread
rahulporuri marked this conversation as resolved.
self.trait_set(**traits)


Expand Down