Use tooltip metadata optionally instead of desc.#473
Merged
Conversation
This implements the suggestion in #472. If a `tooltip` metadata attribute exists for a trait, it is used as is for the tooltip, otherwise the original behavior of using the `'Specifies' + item.desc` is used.
rkern
approved these changes
Jul 25, 2018
Member
rkern
left a comment
rkern
left a comment
There was a problem hiding this comment.
Minor docstring rewording requested, but otherwise LGTM!
| of the item.desc string). | ||
| We also set the help on the QLabel control (from item.help) and the | ||
| tooltip (it item.desc exists; we add "Specifies " at the start of the | ||
| item.desc string, if item.tooltip exists we just use it as is). |
Member
There was a problem hiding this comment.
I would talk about tooltip first rather than second, in order to mirror the code's logic. There are also a couple of errors in the original text that should be fixed. This is how I would write the parenthetical:
(if the ``tooltip`` metadata on the edited trait exists, then it will be used as-is;
otherwise, if the ``desc`` metadata exists, the string "Specifies " will be
prepended to the start of ``desc``)
Member
Author
There was a problem hiding this comment.
Thanks! Done.
prabhuramachandran
added a commit
that referenced
this pull request
Jul 25, 2018
Contributor
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This implements the suggestion in #472. If a
tooltipmetadataattribute exists for a trait, it is used as is for the tooltip,
otherwise the original behavior of using the
'Specifies' + item.descis used.