Skip to content

Move examples/tutorials/tutor.py into traitsui/extras#697

Merged
corranwebster merged 5 commits into
masterfrom
maint/620_move_tutor
Dec 19, 2019
Merged

Move examples/tutorials/tutor.py into traitsui/extras#697
corranwebster merged 5 commits into
masterfrom
maint/620_move_tutor

Conversation

@shoeb-github
Copy link
Copy Markdown
Contributor

resolves #620

  • Moved the bulk of code in examples/tutorials/tutor.py to traits/extras/tutor.py. Also moved the image resources in examples/tutorials/images to traits/extras/images.
  • Added a main function in examples/tutorials/tutor.py that calls the code in traits/extras/tutor.py

@shoeb-github shoeb-github self-assigned this Dec 19, 2019
Copy link
Copy Markdown
Contributor

@corranwebster corranwebster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can see that you have moved the images, but they are not showing up when installed on OS X:

Screen Shot 2019-12-19 at 8 14 51 am

Looking at the installed files, I think you need to update the setup.py to add the new image directory to the package_data. This can be checked by using etstool to install into a new environment and then running the tutor script.

It is also worth checking that the files are included when you build a source distribution (python setup.py sdist if I remember correctly and then look in the dist subdir).

@shoeb-github
Copy link
Copy Markdown
Contributor Author

Thanks for pointing that out. I added the images directory to package_data.

Copy link
Copy Markdown
Contributor

@corranwebster corranwebster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Move examples/tutorial/tutor.py into traitsui/extras

2 participants