Delete tutor.py and add its functionality to demo.py#712
Merged
Conversation
added 12 commits
January 7, 2020 09:19
- so as to make it customizable to handle files other than *py
- different file types are handled by different types of classes.
- the tree walking order and code is taken from old tutor.py
- No longer necessary because the tutor functionality is now in demo.
1 task
corranwebster
approved these changes
Jan 8, 2020
Contributor
corranwebster
left a comment
corranwebster
left a comment
There was a problem hiding this comment.
LGTM
The configuration files can be replaced in a separate PR
Contributor
Author
|
Yes, I will replace them in separate PR. |
This was referenced Apr 27, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contributes to #696
Modified
demo.py:.py.tutor.py).This still does not support
.descfiles from old tutorials. These are config files and it is probably better to rewrite these files in a format support by demo'sconfigobj.