Fix exit code propagation from subcommands#263
Open
lubluniky wants to merge 1 commit intoentireio:mainfrom
Open
Fix exit code propagation from subcommands#263lubluniky wants to merge 1 commit intoentireio:mainfrom
lubluniky wants to merge 1 commit intoentireio:mainfrom
Conversation
main.go previously hardcoded os.Exit(1) for all errors. Subcommands that needed different exit codes (e.g., 2 for usage errors, 128 for signal-related exits) had no way to specify them. This adds an ExitCodeError type that wraps an error with an exit code. main.go now checks for ExitCodeError via errors.As and uses the specified code, falling back to 1 for plain errors. This works through any wrapping chain including SilentError. Closes entireio#256 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ExitCodeErrortype that allows subcommands to specify exit codesmain.goto propagate exit codes instead of always usingos.Exit(1)ExitCodeErrorandSilentErrorwrappingExitCodeErrorCloses #256
Test plan
ExitCodeErrortype (wrapping, unwrapping, errors.As)SilentErrorwrappingExitCodeErrorpropagates codeExitCodeErrorwrappingSilentErroris detectablefmt.Errorfwrapping preservesExitCodeErrorgofmt -s -w .passesgolangci-lint runpasses (no new issues)go test ./cmd/entire/cli/passes🤖 Generated with Claude Code