Conversation
Collaborator
Author
|
@LudwigBoess could you test this on Delta? On stellar it works great! The problem with previous implementation was that we were adding offsets to CPU pointers which is not allowed (since their shape is weird even when you explicitly mirror it). |
Collaborator
|
It works great on DeltaAI too, so I think we can merge this |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Flag
-D gpu_aware_mpiadded which is ON by default. when not compiled with a GPU support, this flag has no effect.Also added a more verbose
.infowhich prints all compilation flags.