fix bug in metadomain.cpp; link library stdc++fs#54
fix bug in metadomain.cpp; link library stdc++fs#54haykh merged 5 commits intoentity-toolkit:1.1.0rcfrom
Conversation
putting stdc++fs only where necessary
needs to be PUBLIC (fixing my own bug)
|
@StaticObserver could you put the ps. I would have done the tweak myself, but i don't have write access to your fork. |
|
also, i tested, and this PR fixes the compilation error in #53. |
|
I'm not very familiar with github, what should I do? Can I change this PR? BTW, I added you to my fork. |
|
@StaticObserver in general, you can simply push to your own fork, and that will automatically update this PR. But no worries, since you opened access, I can now do myself. thanks again for the PR! |
src/framework/metadomain.cpp line 378
INFINITY is float, when precision is double, it causes ambiguity at line 382
linking stdc++fs library in src/CMakelists.txt to void an error at compile time