Skip to content

fix bug in metadomain.cpp; link library stdc++fs#54

Merged
haykh merged 5 commits intoentity-toolkit:1.1.0rcfrom
StaticObserver:v1.0.0rc
Jul 1, 2024
Merged

fix bug in metadomain.cpp; link library stdc++fs#54
haykh merged 5 commits intoentity-toolkit:1.1.0rcfrom
StaticObserver:v1.0.0rc

Conversation

@StaticObserver
Copy link
Collaborator

src/framework/metadomain.cpp line 378
INFINITY is float, when precision is double, it causes ambiguity at line 382

linking stdc++fs library in src/CMakelists.txt to void an error at compile time

@haykh haykh changed the base branch from master to 1.1.0rc June 26, 2024 17:16
haykh added 3 commits June 27, 2024 15:42
putting stdc++fs only where necessary
needs to be PUBLIC (fixing my own bug)
@haykh haykh added the compilation Building/compilation errors label Jun 27, 2024
@haykh
Copy link
Collaborator

haykh commented Jun 27, 2024

@StaticObserver could you put the stdc++fs only in the Makefiles that specifically use the <filesystem> library? That would be two CMakeLists.txt, one in src/global/, and the other in src/output/tests/. link privately, i.e., target_link_library(... PRIVATE stdc++fs). I'm a bit worried this library is not ubiquotous among platforms (i might be wrong), because most of the time the linker finds the correct library for the <filesystem> by itself.

ps. I would have done the tweak myself, but i don't have write access to your fork.

@haykh haykh self-assigned this Jun 27, 2024
@haykh
Copy link
Collaborator

haykh commented Jun 27, 2024

also, i tested, and this PR fixes the compilation error in #53.

@haykh haykh linked an issue Jun 27, 2024 that may be closed by this pull request
@StaticObserver
Copy link
Collaborator Author

I'm not very familiar with github, what should I do? Can I change this PR?

BTW, I added you to my fork.

@haykh
Copy link
Collaborator

haykh commented Jul 1, 2024

@StaticObserver in general, you can simply push to your own fork, and that will automatically update this PR. But no worries, since you opened access, I can now do myself. thanks again for the PR!

@haykh haykh merged commit 86adb2f into entity-toolkit:1.1.0rc Jul 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

compilation Building/compilation errors

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Error when compiling with double precision

2 participants