Bug in phi transformation from Physical to Code-basis

README.md

@@ -30,4 +30,4 @@ Our [detailed documentation](https://entity-toolkit.github.io/) includes everyth
 
 ## Branch policy
 
-Master branch contains the latest stable version of the code which has already been released. Development on the core is done on branches starting with `dev/`. User-specific modifications (i.e., new problem generators plus perhaps minor corrections in the core) are done on branches starting with `pgen/`. Before merging to the master branch, all the branches must first be merged to the latest release-candidate branch, which ends with `rc`, via a pull request. After which, when all the release goals are met, the `rc` branch is merged to the master and released as a new stable version. Stale branches will be archived with a tag starting with `archive/` (can still be accessed via the "Tags" tab) and removed.
+Master branch contains the latest stable version of the code which has already been released. Development on the core is done on branches starting with `dev/`, while fixing bugs is done in branches that start with `bug/`. User-specific modifications (i.e., new problem generators plus perhaps minor corrections in the core) are done on branches starting with `pgen/`. Before merging to the master branch, all the branches must first be merged to the latest release-candidate branch, which ends with `rc`, via a pull request. After which, when all the release goals are met, the `rc` branch is merged to the master and released as a new stable version. Stale branches will be archived with a tag starting with `archive/` (can still be accessed via the "Tags" tab) and removed.

src/metrics/qspherical.h

@@ -317,6 +317,8 @@ namespace metric {
           return v_in * math::exp(xi[0] * dchi + chi_min) * dchi;
         } else if constexpr (i == 2) {
           return v_in * (dtheta_deta(xi[1] * deta + eta_min) * deta);
+        } else if constexpr (D == Dim::_2D) {
+          return v_in;
         } else {
           return v_in * dphi;
         }
@@ -327,6 +329,8 @@ namespace metric {
           return v_in * dchi_inv / (math::exp(xi[0] * dchi + chi_min));
         } else if constexpr (i == 2) {
           return v_in * deta_inv / (dtheta_deta(xi[1] * deta + eta_min));
+        } else if constexpr (D == Dim::_2D) {
+          return v_in;
         } else {
           return v_in * dphi_inv;
         }

src/metrics/spherical.h

@@ -285,6 +285,8 @@ namespace metric {
           return v_in * dr;
         } else if constexpr (i == 2) {
           return v_in * dtheta;
+        } else if constexpr (D == Dim::_2D) {
+          return v_in;
         } else {
           return v_in * dphi;
         }
@@ -295,6 +297,8 @@ namespace metric {
           return v_in * dr_inv;
         } else if constexpr (i == 2) {
           return v_in * dtheta_inv;
+        } else if constexpr (D == Dim::_2D) {
+          return v_in;
         } else {
           return v_in * dphi_inv;
         }