Skip to content

Integer & time measurement types made uniform#86

Merged
haykh merged 4 commits into1.2.0rcfrom
dev/inttypes
Apr 1, 2025
Merged

Integer & time measurement types made uniform#86
haykh merged 4 commits into1.2.0rcfrom
dev/inttypes

Conversation

@haykh
Copy link
Collaborator

@haykh haykh commented Mar 13, 2025

  • All integer types related to particle counting (ranges, numbers, strides), now have npart_t type (aliased to unsigned long long int);
  • All integer types related to the grid resolution (# of cells etc.), now have ncell_t type (aliased to std::size_t);
  • Integer timestep & timestep intervals now have timestep_t (aliased to std::size_t);
  • Code-time in simulation units as well as time intervals have simtime_t (aliased to double);
  • Real-world time duration (e.g., for timers) has a type of duration_t (aliased to double).

This allows to easily & consistently change these types throughout the code (as per weird behavior found on Frontier with long double and std::size_t).

@haykh haykh added bug Something isn't working enhancement New feature or request labels Mar 13, 2025
@haykh haykh requested a review from jmahlmann March 13, 2025 06:03
@haykh haykh merged commit 614e31a into 1.2.0rc Apr 1, 2025
2 checks passed
@haykh haykh deleted the dev/inttypes branch April 1, 2025 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants