fix(search): add clear controls to table search inputs#905
Open
RenzoMXD wants to merge 2 commits intoentrius:testfrom
Open
fix(search): add clear controls to table search inputs#905RenzoMXD wants to merge 2 commits intoentrius:testfrom
RenzoMXD wants to merge 2 commits intoentrius:testfrom
Conversation
Contributor
|
Hi, @RenzoMXD I have already opened pr you mentioned in this. so please review again. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes inconsistent search input behavior by adding clear
Xcontrols to table-level search inputs that previously required manual text deletion.The global search already had a clear button, but several local/table search boxes did not. This PR brings those table search inputs in line with the existing global search behavior and centralizes the clear-button UI in a shared
ClearSearchAdornmentcomponent.Related Issues
Fixes #904
Type of Change
Screenshots
Before:
After:
Checklist
npm run formatandnpm run lint:fixhave been runnpm run buildpasses