fix(watchlist): clear confirmation dialog uses correct tab noun#911
Open
Dexterity104 wants to merge 1 commit intoentrius:testfrom
Open
fix(watchlist): clear confirmation dialog uses correct tab noun#911Dexterity104 wants to merge 1 commit intoentrius:testfrom
Dexterity104 wants to merge 1 commit intoentrius:testfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The clear confirmation dialog on the Watchlist page hard-coded the title to "miner(s)" regardless of the active tab, which contradicted the button caption right beneath it on Repositories, Bounties, Pull Requests, and Issues tabs.
The title now reuses the same
nounhelper (already in scope fromTAB_NOUN[activeTab]) that the confirm button uses, and picksnoun.singleornoun.pluralbased oncount. So a single pinned bounty reads "Clear all 1 pinned bounty?" while five repositories read "Clear all 5 pinned repositories?".Related Issues
Fixes #910
Type of Change
Screenshots
Before
After
Checklist
npm run formatandnpm run lint:fixhave been runnpm run buildpasses