Skip to content

fix(miners): close list tooltips on scroll so they don't float outside the table#920

Open
jerryzai wants to merge 1 commit intoentrius:testfrom
jerryzai:fix/oss_contributions_tooltip_overflow
Open

fix(miners): close list tooltips on scroll so they don't float outside the table#920
jerryzai wants to merge 1 commit intoentrius:testfrom
jerryzai:fix/oss_contributions_tooltip_overflow

Conversation

@jerryzai
Copy link
Copy Markdown
Contributor

@jerryzai jerryzai commented May 1, 2026

Summary

Problem

On the OSS contributions page (miners list view), the username and PR/issue activity-dot tooltips stayed open while the user scrolled the table body. Because the tooltip portal tracks its anchor, the tooltip floated over the sticky toolbar / outside the table once its row scrolled away.

Fix

Swap the in-table Tooltips in MinersList.tsx for ScrollAwareTooltip (existing helper from #876) for the username cell and the activity segment dots. It auto-closes any open tooltip on scroll, so a tooltip can no longer outlive the visible position of its anchor.

Sticky-header tooltips (view-mode toggle, eligibility filter) are unchanged — they don't scroll, so the regular Tooltip is fine.

Test plan

  • OSS contributions page → list view
  • Hover a truncated miner username → tooltip shows; scroll the table → tooltip closes immediately
  • Hover a PR/issue activity dot ("Merged"/"Open"/"Closed") → tooltip shows; scroll → tooltip closes
  • View-mode toggle and eligibility filter tooltips in the sticky header still work normally

Related Issues

Type of Change

  • Bug fix
  • New feature
  • Refactor
  • Documentation
  • Other (describe below)

Screenshots

Before:

Screenshot_2 Screenshot_1
bandicam.2026-05-01.09-39-14-282.mp4

Now:

bandicam.2026-05-01.09-39-58-381.mp4

Checklist

  • New components are modularized/separated where sensible
  • Uses predefined theme (e.g. no hardcoded colors)
  • Responsive/mobile checked
  • Tested against the test API
  • npm run format and npm run lint:fix have been run
  • npm run build passes
  • Screenshots included for any UI/visual changes

@xiao-xiao-mao xiao-xiao-mao Bot added the bug Something isn't working label May 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant