AWS SDK: pass an options hash instead of keyword arguments #371
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The AWS SDK accepts an options hash as arguments, not keyword arguments. We've been relying on Ruby to automatically convert keyword arguments into an options hash. Let's avoid this implicit conversion and explicitly pass an options hash.
stergiom
approved these changes
Jan 31, 2023
stergiom
left a comment
stergiom
left a comment
There was a problem hiding this comment.
👏 Nice. Sorry, late to review (missed this PR somehow).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The AWS SDK accepts an options hash as arguments, not keyword arguments. We've been relying on Ruby to automatically convert keyword arguments into an options hash. This implicit conversion is frowned upon with Ruby 3 and becomes a problem in Ruby 3.2.
Let's avoid this and explicitly pass an options hash.