Fixes for Ruby 3.2 #372
Merged
Fixes for Ruby 3.2 #372
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This resolves the flaky behaviour in CI.
Different versions of Ruby provide different error messages.
This avoids failing specs in development environments where the default region is not us-east-1.
orien
commented
Jan 31, 2023
Comment on lines
-12
to
-15
| before do | ||
| allow(File).to receive(:read).and_return('file content') | ||
| end | ||
|
|
Member
Author
There was a problem hiding this comment.
Avoid stubbing File.read. This resolves the flaky behaviour in CI.
orien
commented
Jan 31, 2023
| allow_any_instance_of(described_class).to receive(:`).with("op --version").and_return(true) | ||
| allow_any_instance_of(described_class).to receive(:`).with("op get item --vault='Shared' 'password title' 2>&1").and_return('{key: value }') | ||
| expect { resolver.resolve(the_password) }.to raise_error(StackMaster::ParameterResolvers::OnePassword::OnePasswordInvalidResponse, /Failed to parse JSON returned, {key: value }: \d+: unexpected token at '{key: value }'/) | ||
| expect { resolver.resolve(the_password) }.to raise_error(StackMaster::ParameterResolvers::OnePassword::OnePasswordInvalidResponse, /Failed to parse JSON returned, {key: value }:.* unexpected token at '{key: value }'/) |
Member
Author
There was a problem hiding this comment.
Be more lenient with the error message expectation here. Different versions of Ruby provide slightly different error messages.
orien
commented
Jan 31, 2023
| let(:outputs) { [] } | ||
|
|
||
| before do | ||
| allow(StackMaster.cloud_formation_driver).to receive(:region).and_return(region) |
Member
Author
There was a problem hiding this comment.
Stub out the default AWS region. This prevents specs failing in development environments where the default
region is not us-east-1.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Ruby 3.2 has been released! Let's get Stack Master working on this.
Change
File.exists?withFile.exist?. This is the only change to files included in the gem.