-
Notifications
You must be signed in to change notification settings - Fork 42
Add SSO group id lookup parameter resolver #390
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add SSO group id lookup parameter resolver #390
Conversation
simpson-ross
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Neat! All seems reasonable, 👍
Remove unused variables and exceptions Harmonise capitalisation of Sso
orien
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome!
Thanks for indulging my many suggestions.
runlevel5
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Remove the need to hardcode magic AWS IIC/SSO group IDs that are required when creating AWS::SSO::Assignment resources
Note: This requires adding a new stack_master.yml toplevel attribute: sso_identity_store_id which is required to do the group lookup. Rather than specifying that in each individual parameter lookup, do it once at the top level.
An example of what this looks like:
Before:
Parameters file:
After:
Parameters file: