Skip to content

Conversation

@andrewjhumphrey
Copy link
Contributor

@andrewjhumphrey andrewjhumphrey commented Jul 10, 2025

Remove the need to hardcode magic AWS IIC/SSO group IDs that are required when creating AWS::SSO::Assignment resources

Note: This requires adding a new stack_master.yml toplevel attribute: sso_identity_store_id which is required to do the group lookup. Rather than specifying that in each individual parameter lookup, do it once at the top level.

An example of what this looks like:

Before:

Parameters file:

SSOArn:
  stack_output: sso-permission-sets-standard/SSOArn
  role: service-role/rolename
  account: '123456789012'
SecurityAdminPermissionSetArn:
  stack_output: sso-permission-sets-standard/SecurityAdminArn
  role: service-role/rolename
  account: '123456789012'
GroupId: "b12345c6-7890-12e3-45b6-b7f89dded0aa"   <---- Needs to be manually fetched from the console/cli

After:

Parameters file:

SSOArn:
  stack_output: sso-permission-sets-standard/SSOArn
  role: service-role/rolename
  account: '123456789012'
SecurityAdminPermissionSetArn:
  stack_output: sso-permission-sets-standard/SecurityAdminArn
  role: service-role/rolename
  account: '123456789012'
GroupId:
  sso_group_id: 'us-east-1:d-123456df7/Okta-App-AWS-Group-name'
  role: service-role/rolename
  account: '123456789012'

Copy link
Contributor

@simpson-ross simpson-ross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neat! All seems reasonable, 👍

Remove unused variables and exceptions
Harmonise capitalisation of Sso
Copy link
Member

@orien orien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

Thanks for indulging my many suggestions.

Copy link
Contributor

@runlevel5 runlevel5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@andrewjhumphrey andrewjhumphrey merged commit 4a85545 into master Jul 11, 2025
20 checks passed
@orien orien deleted the andrewjhumphrey-sso-group-id-parameter-resolverid branch December 7, 2025 00:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants