Skip to content

Remove maintainers section from the readme document #391

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
orien merged 2 commits into from
Dec 8, 2025
Merged

Remove maintainers section from the readme document #391

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
968eead
docs: remove maintainers section from the readme document
orien Dec 7, 2025
3c876f0
tests: avoid matching on error messages that differ by Ruby release
orien Dec 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -794,11 +794,6 @@ CLI directly rather than via a stack update.
applied in CloudFormation. This can happen if the template or computed parameters have changed in code and the change
hasn't been applied to this stack.

## Maintainers

- [Steve Hodgkiss](https://github.com/stevehodgkiss)
- [Glen Stampoultzis](https://github.com/gstamp)

## License

StackMaster uses the MIT license. See [LICENSE.txt](https://github.com/envato/stack_master/blob/master/LICENSE.txt) for details.
Expand Down
4 changes: 2 additions & 2 deletions spec/stack_master/parameter_resolvers/one_password_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,7 +135,7 @@
before do
ENV['OP_SESSION_something'] = 'session'
end

it 'we return an error' do
allow_any_instance_of(described_class).to receive(:`).with("op --version").and_raise(Errno::ENOENT)
expect { resolver.resolve(the_password) }.to raise_error(StackMaster::ParameterResolvers::OnePassword::OnePasswordBinaryNotFound, "The op cli needs to be installed and in the PATH, No such file or directory")
Expand All @@ -158,7 +158,7 @@
it 'we return an error' do
allow_any_instance_of(described_class).to receive(:`).with("op --version").and_return(true)
allow_any_instance_of(described_class).to receive(:`).with("op get item --vault='Shared' 'password title' 2>&1").and_return('{key: value }')
expect { resolver.resolve(the_password) }.to raise_error(StackMaster::ParameterResolvers::OnePassword::OnePasswordInvalidResponse, /Failed to parse JSON returned, {key: value }:.* unexpected token at '{key: value }'/)
expect { resolver.resolve(the_password) }.to raise_error(StackMaster::ParameterResolvers::OnePassword::OnePasswordInvalidResponse, /Failed to parse JSON returned, {key: value }:/)
end
end
end
Expand Down