Skip to content

Jj/docs overhaul#586

Merged
moose-code merged 37 commits intomainfrom
jj/docs-overhaul
Mar 11, 2025
Merged

Jj/docs overhaul#586
moose-code merged 37 commits intomainfrom
jj/docs-overhaul

Conversation

@moose-code
Copy link
Member

No description provided.

@vercel
Copy link

vercel bot commented Mar 10, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
envio-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 11, 2025 5:34pm

@moose-code moose-code requested a review from JasoonS March 10, 2025 18:23
@DZakh
Copy link
Member

DZakh commented Mar 11, 2025

Maybe this section should be called Entities Schema (schema.graphql). Since it's more about entities than graphql

image

@DZakh
Copy link
Member

DZakh commented Mar 11, 2025

I think it would be nice to include more context for the example. Currently it's not super clear where the even should be. I think adding contract config to the example will help

image

@JasoonS
Copy link
Contributor

JasoonS commented Mar 11, 2025

@moose-code - could you briefly note what you did with deleted files. Some of them I assume you have integrated in other sections others were irrelevant.

Will make it much easier to review:)

@moose-code
Copy link
Member Author

Lots of good suggestions @DZakh :) @JasoonS I will make a video showcasing full changes!

I think this can be a first pass, and we improve it more! Lots lots more can still be done

@moose-code
Copy link
Member Author

I think it would be nice to include more context for the example. Currently it's not super clear where the even should be. I think adding contract config to the example will help

image

Definitely, I think this is a recurring theme where there is not enough context in an example.

@moose-code
Copy link
Member Author

moose-code commented Mar 11, 2025

@moose-code moose-code merged commit 0c5d937 into main Mar 11, 2025
2 checks passed
@moose-code moose-code deleted the jj/docs-overhaul branch March 11, 2025 18:01
@DenhamPreen DenhamPreen mentioned this pull request May 21, 2025
@DenhamPreen DenhamPreen mentioned this pull request Jul 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants