Skip to content

Aggregate queries local support only & recommendation#691

Merged
DenhamPreen merged 1 commit intomainfrom
dp/aggregate-warning
Aug 20, 2025
Merged

Aggregate queries local support only & recommendation#691
DenhamPreen merged 1 commit intomainfrom
dp/aggregate-warning

Conversation

@DenhamPreen
Copy link
Contributor

@DenhamPreen DenhamPreen commented Aug 20, 2025

Summary by CodeRabbit

  • Documentation
    • Added “Aggregations: local vs hosted (avoid the foot‑gun)” under Best Practices.
    • Clarifies differences between local Hasura aggregate helpers and the hosted service, and potential pitfalls.
    • Recommends computing and storing aggregates at indexing time, with a practical example workflow.
    • Notes rare cases needing runtime aggregates and directs users to community channels for options.
    • Positioned before “Disable Hasura for Self‑Hosted Indexers” to improve guidance on handling aggregations.

@DenhamPreen DenhamPreen requested a review from moose-code August 20, 2025 11:08
@vercel
Copy link

vercel bot commented Aug 20, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
envio-docs Ready Ready Preview Comment Aug 20, 2025 11:09am

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Aug 20, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

Adds a new Best Practices subsection “Aggregations: local vs hosted (avoid the foot‑gun)” to navigating-hasura.md, advising precomputing aggregates at indexing time due to differences between local and hosted Hasura. Includes schema examples (GlobalState, Token) and a TypeScript handler demonstrating load–increment–persist of counters. Mentions exceptions and Discord pointers.

Changes

Cohort / File(s) Summary
Docs: Hasura aggregation guidance
docs/HyperIndex/Guides/navigating-hasura.md
Inserts a Best Practices section detailing local vs hosted aggregation behavior, recommending indexing-time precomputation with GraphQL schema and TypeScript handler examples; notes rare cases needing runtime aggregates and references Discord.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

A nibble of docs, a hop through Hasura land,
I tally my carrots with counters pre-planned.
Local buns aggregate; hosted says “not quite”—
So I store my sums early, by moonlit byte.
With whiskers of wisdom, I index, then grin—
Foot‑guns avoided, let the queries begin! 🥕🐇

Tip

🔌 Remote MCP (Model Context Protocol) integration is now available!

Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats.


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

💡 Knowledge Base configuration:

  • MCP integration is disabled by default for public repositories
  • Jira integration is disabled by default for public repositories
  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 6ff2725 and af7d022.

📒 Files selected for processing (1)
  • docs/HyperIndex/Guides/navigating-hasura.md (1 hunks)
✨ Finishing Touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch dp/aggregate-warning

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Status, Documentation and Community

  • Visit our Status Page to check the current availability of CodeRabbit.
  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@DenhamPreen DenhamPreen merged commit b11e6a7 into main Aug 20, 2025
2 of 3 checks passed
@DenhamPreen DenhamPreen deleted the dp/aggregate-warning branch August 20, 2025 11:09
Comment on lines +168 to +171

NftContract.Mint.loader((event, context) => {
context.GlobalState.load(globalStateId);
});
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@DenhamPreen This is invalid API

There's also missing await in front of context.GlobalState.get and Handler args are invalid


```graphql
# singleton; you hardcode the id and load it in and out
entity GlobalState {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should be type, not entity @DenhamPreen

@coderabbitai coderabbitai bot mentioned this pull request Aug 20, 2025
This was referenced Aug 20, 2025
@DenhamPreen DenhamPreen mentioned this pull request Sep 1, 2025
This was referenced Oct 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants