Skip to content

cds: rename field, update comments to match design choices #183

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
htuch merged 1 commit into from
Sep 29, 2017
Merged

cds: rename field, update comments to match design choices #183

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 5 additions & 7 deletions api/cds.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -259,19 +259,17 @@ message Cluster {
// Specifications for subsets. For each entry, LbEndpoint.Metadata's
// "envoy.lb" namespace is traversed and a subset is created for each unique
// combination of key and value. For example:
// { "subset_keys": [
// { "subset_selectors": [
// { "keys": [ "version" ] },
// { "keys": [ "stage", "hardware_type" ] }
// ]}
// A subset is matched when the metadata from the selected route and
// weighted cluster contains the keys and values from the subset's
// metadata. Extra keys in the route metadata are ignored when comparing the
// subset's metadata. Subsets may overlap. In the case of overlapping
// subsets, the first matching subset is selected.
message LbSubsetKeys {
// weighted cluster contains the same keys and values as the subset's
// metadata. The same host may appear in multiple subsets.
message LbSubsetSelector {
repeated string keys = 1;
}
repeated LbSubsetKeys subset_keys = 3;
repeated LbSubsetSelector subset_selectors = 3;
}
LbSubsetConfig lb_subset_config = 22;
}