Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
44 commits
Select commit Hold shift + click to select a range
566e122
Adding missing filters
Oct 13, 2017
6aed0e5
adding tcp fault to bazel
Oct 13, 2017
ff6eeea
review feedback
Oct 13, 2017
523a11a
nit
Oct 13, 2017
a00975f
syncing with docs
Oct 16, 2017
867aac0
nit
Oct 16, 2017
a729bc1
cleanups
Oct 17, 2017
9456f27
trying out a longer import
Oct 17, 2017
6b7220f
Merge remote-tracking branch 'upstream/master'
Oct 23, 2017
5e0d5c2
new filters
Oct 23, 2017
3819e57
rate limit and health check filters
Oct 23, 2017
1c0144a
shuffling protos
Oct 24, 2017
e0dd931
fix BUILD
Oct 24, 2017
b867cc5
fix BUILD 2
Oct 24, 2017
e6f8369
feedback
Oct 24, 2017
f331fa8
remove optional percent
Oct 24, 2017
889628a
use wrappers
Oct 24, 2017
8638cbb
BUILD
Oct 24, 2017
8cb7a69
fix
Oct 24, 2017
7502b0c
feedback
Oct 24, 2017
81186d7
moving fault to http
Oct 24, 2017
95286bb
stray build
Oct 24, 2017
7ba311c
beautify bazel build
Oct 24, 2017
3412880
REQUIRED fields
Oct 24, 2017
3d0bfda
Merge remote-tracking branch 'upstream/master'
Oct 24, 2017
f01ef4f
bad commit
Oct 24, 2017
24da3eb
fix
Oct 24, 2017
3abb345
fix
Oct 24, 2017
c7784fb
bad commit
Oct 24, 2017
77ce4e8
fix
Oct 24, 2017
c3665d4
new option to route
Oct 24, 2017
74d96b6
fix cross package ref
Oct 24, 2017
c50c5e9
nits
Oct 25, 2017
69c9237
circle ci
Oct 25, 2017
e86b9e5
Merge remote-tracking branch 'upstream/master'
Oct 25, 2017
b5e4eea
updating docs
Oct 25, 2017
1f13aeb
Merge remote-tracking branch 'upstream/master'
Oct 25, 2017
91bc65f
fix 1
Oct 25, 2017
c22f482
revert
Oct 25, 2017
1a391c4
remove travis
Oct 25, 2017
bc04f80
nits
Oct 25, 2017
5710cec
nits
Oct 25, 2017
6f44ef7
typo
Oct 25, 2017
2c138d9
clarifications
Oct 26, 2017
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 0 additions & 16 deletions .travis.yml

This file was deleted.

22 changes: 17 additions & 5 deletions XDS_PROTOCOL.md
Original file line number Diff line number Diff line change
Expand Up @@ -191,11 +191,23 @@ drop can't be tolerated, traffic drop could have been avoided by providing a
CDS/EDS update with both __X__ and __Y__, then the RDS update repointing from
__X__ to __Y__ and then a CDS/EDS update dropping __X__.

In general, to avoid traffic drop:
* Sequencing should be make before break.
* LDS and CDS updates should arrive before the respective RDS and EDS updates.
* CDS/EDS resources corresponding to routes in LDS/RDS should be available at
update.
In general, to avoid traffic drop, sequencing of updates should follow a
`make before break` model, wherein
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wouldn't use verbatim quotes here, but instead MD emphasis. Not worth changing unless you need another revision though.

* CDS updates (if any) must always be pushed first.
* EDS updates (if any) must arrive after CDS updates for the respective clusters.
* LDS updates must arrive after corresponding CDS/EDS updates.
* RDS updates related to the newly added listeners must arrive in the end.
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should explain the "break" bit afterwards, where you clean up the old clusters (for example).

* Stale CDS clusters and related EDS endpoints (ones no longer being
referenced) can then be removed.

xDS updates can be pushed independently if no new clusters/routes/listeners
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My previous comment on this wasn't reflected in the text here; there are some nuances that should be communicated that were there, in particular around the lack of CDS/EDS warming and the safety of independent updates for new clusters/routes that have no relationship with existing ones.

are added or if it's acceptable to temporarily drop traffic during
updates. Note that in case of LDS updates, the listeners will be warmed
before they receive traffic, i.e. the dependent routes are fetched through
RDS if configured. On the other hand, clusters are not warmed when
adding/removing/updating clusters. Similarly, routes are not warmed --
i.e., the management plane must ensure that clusters referenced by a route
are in place, before pushing the updates for a rotue.

### Aggregated Discovery Services (ADS)

Expand Down
6 changes: 1 addition & 5 deletions ci/build_setup.sh
Original file line number Diff line number Diff line change
Expand Up @@ -9,11 +9,7 @@ NUM_CPUS=`grep -c ^processor /proc/cpuinfo`
export ENVOY_SRCDIR=/source

export BUILD_DIR=/build
if [[ ! -d "${BUILD_DIR}" ]]
then
echo "${BUILD_DIR} mount missing - did you forget -v <something>:${BUILD_DIR}?"
exit 1
fi
mkdir -p ${BUILD_DIR}

# Create a fake home. Python site libs tries to do getpwuid(3) if we don't and
# the CI Docker image gets confused as it has no passwd entry when running
Expand Down
17 changes: 0 additions & 17 deletions ci/ci_steps.sh

This file was deleted.

11 changes: 0 additions & 11 deletions ci/run_envoy_docker.sh

This file was deleted.