Skip to content

cds: update cluster name restrictions in Cluster. #216

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
htuch merged 2 commits into from
Oct 30, 2017
Merged

cds: update cluster name restrictions in Cluster. #216

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
13fc9f2
cds: update cluster name restrictions in Cluster.
htuch Oct 30, 2017
a29f4e8
TODO to add cross-link to CLI docs.
htuch Oct 30, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions api/cds.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,8 +63,9 @@ message CircuitBreakers {

message Cluster {
// Supplies the name of the cluster which must be unique across all clusters.
// The cluster name is used when emitting statistics. The cluster name can be
// at most 60 characters long, and must not contain :.
// Any : in the cluster name will be converted to _ when emitting statistics.
Copy link
Copy Markdown
Member

@mattklein123 mattklein123 Oct 30, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FWIW this is the kind of place in which we would cross link to the CLI option. Might be worth putting a doc TODO in here.

// TODO(htuch): cross-link to
// https://www.envoyproxy.io/envoy/operations/cli#cmdoption-max-obj-name-len.
string name = 1;

// The service discovery type to use for resolving the cluster.
Expand Down