Skip to content

redirect: allow to specify redirect response code #217

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ccaraman merged 5 commits into from
Nov 1, 2017
Merged

redirect: allow to specify redirect response code #217

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
661bdaa
redirect: Add HTTP response codes.
ccaraman Oct 30, 2017
2b79050
Change values to match code value
ccaraman Oct 30, 2017
9458f9f
Fixed comments
ccaraman Oct 30, 2017
05b3423
Make proto3 happy with enums starting at 0.
ccaraman Oct 30, 2017
3288632
Add 303 and 304 status codes and rename enum class.
ccaraman Nov 1, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 18 additions & 6 deletions api/rds.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -285,12 +285,24 @@ message RouteAction {
}

message RedirectAction {
// A 302 redirect response will be sent which swaps the host portion of the
// URL with this value.
// The host portion of the URL will be swapped with this value.
string host_redirect = 1;
// A 302 redirect response will be sent which swaps the path portion of the
// URL with this value.
// The path portion of the URL will be swapped with this value.
string path_redirect = 2;

enum RedirectResponseCode {
// Moved Permanently HTTP Status Code - 301.
MOVED_PERMANENTLY = 0;
// Found HTTP Status Code - 302.
FOUND = 1;
// See Other HTTP Status Code - 303.
SEE_OTHER = 2;
// Not Modified HTTP Status Code - 304.
NOT_MODIFIED = 3;
}
// The HTTP status code to use in the redirect response. The default response
// code is MOVED_PERMANENTLY (301).
RedirectResponseCode response_code = 3;
}

message Decorator {
Expand Down Expand Up @@ -461,9 +473,9 @@ message VirtualHost {
// No TLS requirement for the virtual host.
NONE = 0;
// External requests must use TLS. If a request is external and it is not
// using TLS, a 302 redirect will be sent telling the client to use HTTPS.
// using TLS, a 301 redirect will be sent telling the client to use HTTPS.
Copy link
Member

@rshriram rshriram Oct 31, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

EXTERNAL_ONLY = 1;
// All requests must use TLS. If a request is not using TLS, a 302 redirect
// All requests must use TLS. If a request is not using TLS, a 301 redirect
// will be sent telling the client to use HTTPS.
ALL = 2;
}
Expand Down