Skip to content

Add "crl" field to CertificateValidationContext #249

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
adunham-stripe wants to merge 1 commit into from
Closed

Add "crl" field to CertificateValidationContext #249

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions api/sds.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,6 +93,9 @@ message CertificateValidationContext {

// Must present signed certificate time-stamp.
google.protobuf.BoolValue require_signed_certificate_timestamp = 6;

// If specified, Envoy will verify certificates against this CRL.
Copy link
Copy Markdown
Member

@ggreenway ggreenway Nov 17, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are there multiple possible formats (anything besides PEM)? If so, please document the expected format.

DataSource crl = 7;
Copy link
Copy Markdown
Member

@mattklein123 mattklein123 Nov 19, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Per your other PR in which you mention having multiple CRLs, should this be repeated? (From an API perspective please future-proof it).

}

// TLS context shared by both client and server TLS contexts.
Expand Down