Adding a configuration option for proxying 100 continue#433
Merged
htuch merged 3 commits intoenvoyproxy:masterfrom Jan 25, 2018
Merged
Adding a configuration option for proxying 100 continue#433htuch merged 3 commits intoenvoyproxy:masterfrom
htuch merged 3 commits intoenvoyproxy:masterfrom
Conversation
Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
htuch
approved these changes
Jan 25, 2018
mattklein123
approved these changes
Jan 25, 2018
Member
mattklein123
left a comment
mattklein123
left a comment
There was a problem hiding this comment.
LGTM. Can we not merge until @kyessenov big PR merges?
Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
alyssawilk
added a commit
to envoyproxy/envoy
that referenced
this pull request
Feb 6, 2018
By default Envoy will still strip Expect: 100-Continue and send the 100 Continue response, but for each HttpConnectionManager configured to proxy_100_continue it will pass the header through and proxy the 100 Continue from upstream. Risk Level: Medium-High (http connection manager refactor) Testing: thorough unit tests and integration tests Docs Changes: envoyproxy/data-plane-api#455 Fixes #2325 [API Changes:] envoyproxy/data-plane-api#433
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For envoyproxy/envoy#2325