Skip to content

Add unauthorized boolean the accesslog. #505

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
htuch merged 7 commits into from
Mar 1, 2018
Merged

Add unauthorized boolean the accesslog. #505

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
ab6d6d6
Add unauthorized boolean the accesslog.
Feb 20, 2018
ed60e39
Add proposal for unauthorized with enum.
Feb 23, 2018
15096fa
Merge remote-tracking branch 'upstream/master' into access-log
Feb 23, 2018
092798f
Remove boolean is_unauthorized.
Feb 24, 2018
59753d7
Address review comment.
Feb 28, 2018
62c8673
Use better names.
Feb 28, 2018
ba93510
Merge remote-tracking branch 'upstream/master' into access-log
Feb 28, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions envoy/config/filter/accesslog/v2/accesslog.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,6 +147,20 @@ message ResponseFlags {

// Indicates that the request was rate-limited locally.
bool rate_limited = 12;

message Unauthorized {
// Reasons why the request was unauthorized
enum Reason {
REASON_UNSPECIFIED = 0;
// The request was denied by the external authorization service.
EXTERNAL_SERVICE = 1;
}

Reason reason = 1;
}

// Indicates if the request was deemed unauthorized and the reason for it.
Unauthorized unauthorized_details = 13;
}

// [#not-implemented-hide:] Not configuration. TBD how to doc proto APIs.
Expand Down