tcp proxy: add metadata_match to tcp proxy config#520
Merged
ggreenway merged 2 commits intoenvoyproxy:masterfrom Mar 2, 2018
Merged
tcp proxy: add metadata_match to tcp proxy config#520ggreenway merged 2 commits intoenvoyproxy:masterfrom
ggreenway merged 2 commits intoenvoyproxy:masterfrom
Conversation
added 2 commits
March 1, 2018 19:23
This should allow the tcp proxy to target a specific subset of endpoints in a cluster by matching on the metadata, similar to what is currently possible in the http_connection_manager filter. See envoyproxy/envoy#2696 Signed-off-by: Snow Pettersen <snowp@squareup.com>
Signed-off-by: Snow Pettersen <snowp@squareup.com>
Member
|
Looks good to me, @zuercher can you drive the review on the API and implementation side for this given that you did the original subset LB? |
zuercher
approved these changes
Mar 2, 2018
Member
zuercher
left a comment
zuercher
left a comment
There was a problem hiding this comment.
Looks good. Do you want to leave this open while you publish a first pass at the Envoy PR? (It's up to you, I don't think this will need to change.)
Contributor
Author
|
I think this is fine to merge. I'll try to get the enovy PR up sometime today or this weekend |
ggreenway
approved these changes
Mar 2, 2018
alyssawilk
pushed a commit
to envoyproxy/envoy
that referenced
this pull request
Mar 8, 2018
…2708) Description: This implements metadata_match for the tcp filter, which will allow users to specify a metadata criteria that specifies what endpoints should be considered selecting an upstream connection to the cluster. Risk Level: Low Small optional feature Testing: Added a unit test that verifies that TcpFilter#metadataMatchCriteria returns the criteria specified in the config. Release Notes: Added support for specifying a metadata matcher for upstream clusters in the tcp filter Fixes #2696 API Changes envoyproxy/data-plane-api#520 Signed-off-by: Snow Pettersen <snowp@squareup.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should allow the tcp proxy to target a specific subset of endpoints
in a cluster by matching on the metadata, similar to what is currently
possible in the http_connection_manager filter.
See envoyproxy/envoy#2696
Signed-off-by: Snow Pettersen snowp@squareup.com