bazel: add .bazelrc and use Bazel's import instead of symlinking.#66
Conversation
| @@ -0,0 +1 @@ | |||
| envoy/.bazelrc No newline at end of file | |||
There was a problem hiding this comment.
Do you mean import envoy/.bazelrc ?
There was a problem hiding this comment.
import envoy/.bazelrc would also work, but this symbolic link pointing to .bazelrc inside envoy submodule (which isn't obvious when reviewing on GitHub) is used for consistency with how it's done for tools/bazel.rc.
I don't have any preference, really, @htuch?
There was a problem hiding this comment.
Oh, I wasn't aware of this is a symbolic link, it's GItHub's failure ;) either way works for me too.
This is future-proofing, since %workspace%/tools/bazel.rc won't be automatically processed starting with Bazel 0.19 (October 2018). Signed-off-by: Piotr Sikora <piotrsikora@google.com>
PiotrSikora
changed the title
|
@htuch PTAL. |
htuch
left a comment
htuch
left a comment
There was a problem hiding this comment.
For tools/bazel.rc, you can nuke this one, since we are using this repo to demonstrate best practice and nobody should be depending on it.
Signed-off-by: Piotr Sikora <piotrsikora@google.com>
|
@htuch done. |
|
Oops, nuking that file broke things completely, since |
3 participants
This is future-proofing, since %workspace%/tools/bazel.rc won't be
automatically processed starting with Bazel 0.19 (October 2018).
Signed-off-by: Piotr Sikora piotrsikora@google.com