Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion BUILD
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,6 @@ envoy_cc_library(
repository = "@envoy",
deps = [
":echo2_lib",
"@envoy//include/envoy/network:connection_interface",
"@envoy//source/server:configuration_lib",
],
)
Expand Down
16 changes: 5 additions & 11 deletions echo2_config.cc
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
#include "envoy/network/connection.h"
#include <string>

#include "echo2.h"
#include "server/configuration_impl.h"
Expand All @@ -13,19 +13,13 @@ namespace Configuration {
class Echo2ConfigFactory : public NamedNetworkFilterConfigFactory {
public:
// NamedNetworkFilterConfigFactory
NetworkFilterFactoryCb createFilterFactory(NetworkFilterType type, const Json::Object&,
Server::Instance&) override {
if (type != NetworkFilterType::Read) {
throw EnvoyException(
fmt::format("{} network filter must be configured as a read filter.", name()));
}

return [](Network::FilterManager& filter_manager) -> void {
filter_manager.addReadFilter(Network::ReadFilterSharedPtr{new Filter::Echo2()});
};
NetworkFilterFactoryCb createFilterFactory(const Json::Object&, FactoryContext&) override {
return [](Network::FilterManager& filter_manager)
-> void { filter_manager.addReadFilter(Network::ReadFilterSharedPtr{new Filter::Echo2()}); };
}

std::string name() override { return "echo2"; }
NetworkFilterType type() override { return NetworkFilterType::Read; }
};

/**
Expand Down
2 changes: 1 addition & 1 deletion envoy
Submodule envoy updated from ddf9cc to e9c56d