python: envoy_requests depend on a specific version of protobuf#1504
Closed
python: envoy_requests depend on a specific version of protobuf#1504
Conversation
Signed-off-by: Cerek Hillen <chillen@lyft.com>
Contributor
|
Re-running unit tests since I don't see any output as to the what the failure was in GitHub Actions. |
Contributor
Author
|
closing since this isn't the right fix. see #1506 for more details |
goaway
pushed a commit
that referenced
this pull request
Jun 8, 2021
Description: This PR modifies the build recipe for `envoy_engine.so` to hide all symbols except for `_PyInit_envoy_engine` by default on maOS, so that envoy_engine can be loaded alongside a [protobuf](http://pypi.org/project/protobuf) wheel without breaking. Loading in protobuf alongside `envoy_engine.so` would register two sets of the same symbols and, on macOS, the runtime linker chooses the first symbol it finds causing problems. See the [similar protobuf change](protocolbuffers/protobuf#8346) and its [sister change in grpc](grpc/grpc#24992) for more information on what's going on. Risk Level: Low Testing: See the now-closed #1504 for how I've been testing this. Docs Changes: N/A Release Notes: N/A Signed-off-by: Cerek Hillen <chillen@lyft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description: This PR introduces a requirement that consumers of envoy-requests must have
protobuf==3.17to prevent crashes. I've been able to consistently reproduce crashes in Python applications on the main branch by://library/python:envoy_requests_whlonmainprotobuf==3.14(previous version before envoy bump) orprotobuf==3.16(current version after envoy bump)protobuf==3.14protobuf==3.16This succeeds when running
protobuf==3.17, however, hence the version I've chosen to require.I've narrowed this problem down to an indirect import of
google.protobuf.pyext._message. Importing that module calls InitProto2MessageModule which does a lot of initialization, but I'm not sure which part causes the problem. I'm still struggling to understand how this all happens, so if anyone has any ideas I'd love to hear them!Risk Level: Low
Testing: Documented above
Docs Changes: N/A
Release Notes: N/A