Merged
Conversation
added 4 commits
October 28, 2021 16:32
Signed-off-by: Jose Nino <jnino@lyft.com>
Signed-off-by: Jose Nino <jnino@lyft.com>
Signed-off-by: Jose Nino <jnino@lyft.com>
Signed-off-by: Jose Nino <jnino@lyft.com>
goaway
approved these changes
Oct 29, 2021
Contributor
|
This probably doesn't matter much, but I think the PR that introduced this CPP 17 functionality not present in the iOS 12 libraries was first introduced in v3.10.4 (nlohmann/json#3073), meaning we could still bump the dependency up from our current v3.10.2 to v3.10.3. There doesn't appear to be any significant improvements or bug fixes in v3.10.3 for this to matter much though: nlohmann/json@v3.10.2...v3.10.3 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Additional Info:
Signed-off-by: Jose Nino jnino@lyft.com