Error building envoy on ppc64le

[rashmi-ibm]

Installed Dependencies with version:-

[root@d7f1b4d1bfca /]# gcc --version
gcc (GCC) 8.3.1 20191121 (Red Hat 8.3.1-5)
Copyright (C) 2018 Free Software Foundation, Inc.
This is free software; see the source for copying conditions. There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.

[root@d7f1b4d1bfca /]# g++ --version
g++ (GCC) 8.3.1 20191121 (Red Hat 8.3.1-5)
Copyright (C) 2018 Free Software Foundation, Inc.
This is free software; see the source for copying conditions. There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.

[root@d7f1b4d1bfca /]#
[root@d7f1b4d1bfca /]# go version
go version go1.13.5 linux/ppc64le
[root@d7f1b4d1bfca /]# bazel --version
bazel 3.4.0- (@Non-Git)
[root@d7f1b4d1bfca /]# ninja --version
1.8.2
[root@d7f1b4d1bfca /]# python --version
Python 3.6.8

Build command:-
bazel build -c opt //source/exe:envoy-static --verbose_failures --copt "-DENVOY_IGNORE_GLIBCXX_USE_CXX11_ABI_ERROR=1" --cxxopt=-std=gnu++0x

Build failure error:-

external/com_lightstep_tracer_cpp/src/common/utility.cpp: In function 'void lightstep::WriteEscapedString(std::ostringstream&, opentracing::v2::string_view)':
external/com_lightstep_tracer_cpp/src/common/utility.cpp:75:20: error: comparison is always true due to limited range of data type [-Werror=type-limits]
75 | if ('\x00' <= c && c <= '\x1f') {
| ~~~~~~~^~~~
cc1plus: all warnings being treated as errors
Target //source/exe:envoy-static failed to build
INFO: Elapsed time: 104.218s, Critical Path: 89.10s
INFO: 179 processes: 179 processwrapper-sandbox.
FAILED: Build did NOT complete successfully
[root@d7f1b4d1bfca envoy]#

[junr03]

cc @lizan

[dmitri-d]

FFIW, we do ppc64le builds, but on RHEL8/gcc 9.3. Envoy CI uses gcc 9 too.

[rashmi-ibm]

I used gcc 9 but still getting the same error:-
Warnings are being treated as errors is there a flag to ignore that?

Use --sandbox_debug to see verbose messages from the sandbox gcc failed: error executing command
(cd /root/.cache/bazel/_bazel_root/4e47b77d977b209382cf04b3ae32963e/sandbox/processwrapper-sandbox/3011/execroot/envoy &&
exec env -
BAZEL_LINKLIBS=-l%:libstdc++.a
BAZEL_LINKOPTS=-lm
CC=/opt/rh/gcc-toolset-9/root/usr/bin/gcc
CXX=/opt/rh/gcc-toolset-9/root/usr/bin/g++
PATH=/usr/lib/jvm/java-1.8.0-openjdk-1.8.0.252.b09-3.el8_2.ppc64le/bin:/opt/rh/gcc-toolset-9/root/usr/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/usr/local/go/bin:/root/go/bin:/root/go/bin:/root/gn/out
PWD=/proc/self/cwd
/opt/rh/gcc-toolset-9/root/usr/bin/gcc -U_FORTIFY_SOURCE -fstack-protector -Wall -Wunused-but-set-parameter -Wno-free-nonheap-object -fno-omit-frame-pointer -g0 -O2 '-D_FORTIFY_SOURCE=1' -DNDEBUG -ffunction-sections -fdata-sections '-std=c++0x' -MD -MF bazel-out/ppc-opt/bin/external/com_lightstep_tracer_cpp/src/common/_objs/utility_lib/utility.d '-frandom-seed=bazel-out/ppc-opt/bin/external/com_lightstep_tracer_cpp/src/common/_objs/utility_lib/utility.o' -iquote external/com_lightstep_tracer_cpp -iquote bazel-out/ppc-opt/bin/external/com_lightstep_tracer_cpp -iquote external/com_google_protobuf -iquote bazel-out/ppc-opt/bin/external/com_google_protobuf -iquote external/io_opentracing_cpp -iquote bazel-out/ppc-opt/bin/external/io_opentracing_cpp -iquote external/com_google_googleapis -iquote bazel-out/ppc-opt/bin/external/com_google_googleapis -Ibazel-out/ppc-opt/bin/external/com_lightstep_tracer_cpp/src/common/_virtual_includes/utility_lib -Ibazel-out/ppc-opt/bin/external/io_opentracing_cpp/_virtual_includes/opentracing -Ibazel-out/ppc-opt/bin/external/io_opentracing_cpp/3rd_party/_virtual_includes/expected -Ibazel-out/ppc-opt/bin/external/io_opentracing_cpp/3rd_party/_virtual_includes/variant -Ibazel-out/ppc-opt/bin/external/com_lightstep_tracer_cpp/src/common/platform/_virtual_includes/time_lib -Ibazel-out/ppc-opt/bin/external/com_google_protobuf/_virtual_includes/descriptor_proto -Ibazel-out/ppc-opt/bin/external/com_google_protobuf/_virtual_includes/timestamp_proto -Ibazel-out/ppc-opt/bin/external/com_lightstep_tracer_cpp/src/common/virtual_includes/logger_lib -Ibazel-out/ppc-opt/bin/external/com_lightstep_tracer_cpp/include/lightstep/virtual_includes/tracer_interface -Ibazel-out/ppc-opt/bin/external/com_lightstep_tracer_cpp/include/lightstep/virtual_includes/transporter_interface -Ibazel-out/ppc-opt/bin/external/com_lightstep_tracer_cpp/include/lightstep/virtual_includes/buffer_chain_interface -Ibazel-out/ppc-opt/bin/external/com_lightstep_tracer_cpp/include/lightstep/virtual_includes/metrics_observer_interface -Ibazel-out/ppc-opt/bin/external/com_lightstep_tracer_cpp/src/common/virtual_includes/hex_conversion_lib -isystem external/com_google_protobuf/src -isystem bazel-out/ppc-opt/bin/external/com_google_protobuf/src -isystem bazel-out/ppc-opt/bin/external/envoy/bazel/foreign_cc/zlib/include -fPIC '-DENVOY_IGNORE_GLIBCXX_USE_CXX11_ABI_ERROR=1' '-std=gnu++0x' -Iexternal/com_lightstep_tracer_cpp/include -Ibazel-out/ppc-opt/binexternal/com_lightstep_tracer_cpp//include -Iexternal/com_lightstep_tracer_cpp/src -Ibazel-out/ppc-opt/binexternal/com_lightstep_tracer_cpp//src -Iexternal/com_lightstep_tracer_cpp/test -Ibazel-out/ppc-opt/binexternal/com_lightstep_tracer_cpp//test -isystem external/com_lightstep_tracer_cpp/3rd_party/base64/include -isystem bazel-out/ppc-opt/binexternal/com_lightstep_tracer_cpp//3rd_party/base64/include -Wall -Wextra -Werror -Wnon-virtual-dtor -Woverloaded-virtual -Wold-style-cast -Wno-overloaded-virtual -Wvla '-std=c++11' -fno-canonical-system-headers -Wno-builtin-macro-redefined '-D__DATE="redacted"' '-D__TIMESTAMP="redacted"' '-D__TIME="redacted"' -c external/com_lightstep_tracer_cpp/src/common/utility.cpp -o bazel-out/ppc-opt/bin/external/com_lightstep_tracer_cpp/src/common/_objs/utility_lib/utility.o)
Execution platform: @local_config_platform//:host

Use --sandbox_debug to see verbose messages from the sandbox
external/com_lightstep_tracer_cpp/src/common/utility.cpp: In function 'void lightstep::WriteEscapedString(std::ostringstream&, opentracing::v2::string_view)':
external/com_lightstep_tracer_cpp/src/common/utility.cpp:75:20: error: comparison is always true due to limited range of data type [-Werror=type-limits]
75 | if ('\x00' <= c && c <= '\x1f') {
| ~~~~~~~^~~~
cc1plus: all warnings being treated as errors
Target //source/exe:envoy-static failed to build
INFO: Elapsed time: 1230.512s, Critical Path: 225.97s
INFO: 3011 processes: 3011 processwrapper-sandbox.
FAILED: Build did NOT complete successfully
[root@d1b5dcc5025e envoy]# gcc --version
gcc (GCC) 9.2.1 20191120 (Red Hat 9.2.1-2)
Copyright (C) 2019 Free Software Foundation, Inc.
This is free software; see the source for copying conditions. There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.

[root@d1b5dcc5025e envoy]# g++ --version
g++ (GCC) 9.2.1 20191120 (Red Hat 9.2.1-2)
Copyright (C) 2019 Free Software Foundation, Inc.
This is free software; see the source for copying conditions. There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.

[root@d1b5dcc5025e envoy]# bazel --version
bazel 3.4.0- (@Non-Git)
[root@d1b5dcc5025e envoy]#

[lizan]

Don't add --cxxopt=-std=gnu++0x, we're now on C++17, gnu++0x never work

[rashmi-ibm]

@lizan I removed the --cxxopt option but the error remains the same.

Build command:-
#bazel build -c opt //source/exe:envoy-static --verbose_failures --copt "-DENVOY_IGNORE_GLIBCXX_USE_CXX11_ABI_ERROR=1"

#bazel build -c opt //source/exe:envoy-static

ERROR: /root/.cache/bazel/_bazel_root/4e47b77d977b209382cf04b3ae32963e/external/com_lightstep_tracer_cpp/src/common/BUILD:173:21: C++ compilation of rule '@com_lightstep_tracer_cpp//src/common:utility_lib' failed (Exit 1) gcc failed: error executing command /opt/rh/gcc-toolset-9/root/usr/bin/gcc -U_FORTIFY_SOURCE -fstack-protector -Wall -Wunused-but-set-parameter -Wno-free-nonheap-object -fno-omit-frame-pointer -g0 -O2 '-D_FORTIFY_SOURCE=1' -DNDEBUG ... (remaining 71 argument(s) skipped)

Use --sandbox_debug to see verbose messages from the sandbox
external/com_lightstep_tracer_cpp/src/common/utility.cpp: In function 'void lightstep::WriteEscapedString(std::ostringstream&, opentracing::v2::string_view)':
external/com_lightstep_tracer_cpp/src/common/utility.cpp:75:20: error: comparison is always true due to limited range of data type [-Werror=type-limits]
75 | if ('\x00' <= c && c <= '\x1f') {
| ~~~~~~~^~~~
cc1plus: all warnings being treated as errors
Target //source/exe:envoy-static failed to build
Use --verbose_failures to see the command lines of failed build steps.
INFO: Elapsed time: 396.617s, Critical Path: 181.61s
INFO: 1582 processes: 1582 processwrapper-sandbox.
FAILED: Build did NOT complete successfully
[root@d1b5dcc5025e envoy]#

[dmitri-d]

I just checked build options we use in maistra builds, and we have "-w" which turns off all warnings. A better approach would be to use "-Wno-error=type-limits", or better still fix the issue in upstream.

[dmitri-d]

@rashmi-ibm: I'm not exactly sure why gcc build fails for you, it could be down to differences in compiler versions used -- the CI is on gcc 9.3.x, the compiler version in your environment is 9.2.

[rashmi-ibm]

@dmitri-d as per the below link the official version is 9.2 . Will try to see gcc 9.3.x...
https://access.redhat.com/documentation/en-us/red_hat_enterprise_linux/8/html/developing_c_and_cpp_applications_in_rhel_8/gcc-toolset-9_toolsets

[snehagg24]

@dmitri-d I am able to build envoy using "-Wno-error=type-limits". However I am getting below error while executing tests:
ERROR: /root/envoy/test/mocks/upstream/BUILD:11:14: C++ compilation of rule '//test/mocks/upstream:cluster_info_mocks' failed (Exit 1) gcc failed: error executing command /opt/rh/gcc-toolset-9/root/usr/bin/gcc -U_FORTIFY_SOURCE -fstack-protector -Wall -Wunused-but-set-parameter -Wno-free-nonheap-object -fno-omit-frame-pointer '-std=c++0x' -MD -MF ... (remaining 527 argument(s) skipped)
Most of the tests are getting skipped because of this. Sometimes one or two tests ran and passed.

Command used for tests: bazel test //test/... --test_env=ENVOY_IP_TEST_VERSIONS=v4only --host_javabase=@local_jdk//:jdk --copt "-Wno-error=type-limits" (Also tried it without --test_env and --host_javabase; got same error)

gcc --version :
gcc (GCC) 9.2.1 20191120 (Red Hat 9.2.1-2)
Copyright (C) 2019 Free Software Foundation, Inc.
This is free software; see the source for copying conditions. There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.

[dmitri-d]

Could you post a complete contents of the error log? The message that you posted doesn't contain enough details to explain what went wrong.

[snehagg24]

envoyBuildLog.txt
envoyTestLog.txt
@dmitri-d I have attached build and test logs for reference.

[dmitri-d]

There's no error in envoyTestLog, just the message that a test failed to build. You could try adding --sandbox_debug to the bazel test, or try running just the test that's failing to building.

[snehagg24]

@dmitri-d I can see below error in the log that I posted:
ERROR: /root/envoy/test/common/http/BUILD:351:19: C++ compilation of rule '//test/common/http:utility_fuzz_test_lib' failed (Exit 1) gcc failed: error executing command /opt/rh/gcc-toolset-9/root/usr/bin/gcc -U_FORTIFY_SOURCE -fstack-protector -Wall -Wunused-but-set-parameter -Wno-free-nonheap-object -fno-omit-frame-pointer '-std=c++0x' -MD -MF ... (remaining 593 argument(s) skipped)
I came across this issue #9962 in which a similar failure is reported.
I tried adding --sandbox_debug but didn't get any more info as such. Pasting the log for reference.
envoytestlog_withSandboxDebug.txt

Also everytime a different test fails to build. So trying to figure out which test is causing the issue.
Let me know if you have any pointers on this.

[dmitri-d]

Also everytime a different test fails to build.

You can try building/running a particular test suite by specifying the path to it in bazel test command: bazel test //test/common/http:test_suite.

I'd try executing the failing command shown in the debug output, but using gcc directly (I think you can skip everything up to /opt/rh/gcc-toolset-9/root/usr/bin/gcc).