Shasum not found when building on linux

[rickeyski]

#4594 breaks non osx builds

I tried to do a clean build of master on amazon linux and build fails being unable to build dependencies because shasum is not found

Command:

$ bazel build -c opt //source/exe:envoy-static

Ouput:

+ 1538697685.888074831 . /mnt/d1/envoy/ci/build_container/build_recipes/yaml-cpp.sh
++ 1538697685.889424139 set -e
++ 1538697685.890854062 COMMIT=0f9a586ca1dc29c2ecb8dd715a315b93e3f40f79
++ 1538697685.892820626 SHA256=53dcffd55f3433b379fcc694f45c54898711c0e29159a7bd02e82a3e0253bac3
++ 1538697685.894361472 curl https://github.com/jbeder/yaml-cpp/archive/0f9a586ca1dc29c2ecb8dd715a315b93e3f40f79.tar.gz -sLo yaml-cpp-0f9a586ca1dc29c2ecb8dd715a315b93e3f40f79.tar.gz
++ 1538697686.395488765 echo '53dcffd55f3433b379fcc694f45c54898711c0e29159a7bd02e82a3e0253bac3 ' yaml-cpp-0f9a586ca1dc29c2ecb8dd715a315b93e3f40f79.tar.gz
++ 1538697686.395603226 shasum -a 256 --check
/mnt/d1/envoy/ci/build_container/build_recipes/yaml-cpp.sh: line 10: shasum: command not found

real	0m0.511s
user	0m0.028s
sys	0m0.019s
make: *** [/mnt/d2/_bazel_ec2-user/5e31c7cc260f59a4ff7578e8ccd0001e/external/envoy_deps_cache_2c744dffd279d7e9e0910ce594eb4f4f/yaml-cpp.dep] Error 1
Successful build of /mnt/d2/_bazel_ec2-user/5e31c7cc260f59a4ff7578e8ccd0001e/external/envoy_deps_cache_2c744dffd279d7e9e0910ce594eb4f4f/benchmark.dep
make: Leaving directory `/mnt/d2/_bazel_ec2-user/5e31c7cc260f59a4ff7578e8ccd0001e/external/envoy_deps'
DEBUG: /mnt/d1/envoy/bazel/repositories.bzl:121:5: External dep build exited with return code: 1
DEBUG: /mnt/d1/envoy/bazel/repositories.bzl:123:9:  External dependency build failed, check above log for errors and ensure all prerequisites at https://github.com/envoyproxy/envoy/blob/master/bazel/README.md#quick-start-bazel-build-for-developers are met.
ERROR: /mnt/d1/envoy/bazel/repositories.bzl:272:13: no such package '@envoy_deps//': External dep build failed and referenced by '//external:tcmalloc_and_profiler'
ERROR: Analysis of target '//source/exe:envoy-static' failed; build aborted: Analysis failed
INFO: Elapsed time: 18.323s
INFO: 0 processes.
FAILED: Build did NOT complete successfully (289 packages loaded)

after running

$ git revert d67601d532391f985ec839fdd78a84993b34ed05

the build completes successfully

Letting osx users alias sha256sum='shasum -a 256' seems to be much more portable than relying solely on shasum. Please let me know if I am missing something to build on linux instead.

Rickey

[mattklein123]

@lizan

[dio]

IIRC, sha256sum for osx is in coreutils (/usr/local/opt/coreutils/libexec/gnubin/sha256sum) it is one of the requirements to be installed as listed in: https://github.com/envoyproxy/envoy/blob/master/bazel/README.md#quick-start-bazel-build-for-developers.

[moderation]

That is what we (my PR with help from @zuercher) relied on when we added https://github.com/envoyproxy/envoy/pull/4594/files#diff-9edaf9e02ff4feba62dd04460bd3a6eeL5. This was still working for me in 10.14. it seems like the move to shasum is causing the issue on some Linux distros.

[lizan]

Hmm I thought shasum with -a works both mac and Linux but seems only ubuntu has it by default. Let me revert that part and comes with better solution. a PR will be out soon.