Add client capability for not supporting overprovisioning.#10136
Add client capability for not supporting overprovisioning.#10136mattklein123 merged 6 commits intoenvoyproxy:masterfrom
Conversation
Signed-off-by: Mark D. Roth <roth@google.com>
|
/cc |
|
Thanks LGTM, though I think needs a format/doc fix. Also, if the field will not be used, can you just go ahead and "deprecate" it from v2 and then it will be removed in v3? I think that's fine to do if it was never implemented. Thank you! /wait |
Signed-off-by: Mark D. Roth <roth@google.com>
Signed-off-by: Mark D. Roth <roth@google.com>
|
I've marked the I've attempted to fix the formatting. Let's see if the CI is happy... |
Signed-off-by: Mark D. Roth <roth@google.com>
|
@mattklein123 The remaining CI failure seems like a bug in the formatter. It wants me to pull in the end of the table, but doing that would break the RST formatting. I'm not sure how to fix this. Can you (or someone who better understand the CI checks) please take a look? Thanks! |
|
Sadly I don't know what the issue is and I don't have the cycles to debug it right now. @envoyproxy/maintainers is there anyone that can help look at this format check? |
Signed-off-by: Mark D. Roth <roth@google.com>
|
I've punted by removing the table and replacing it with a bulleted list. |
Signed-off-by: Mark D. Roth <roth@google.com>
Signed-off-by: Mark D. Roth roth@google.com
Description: Add client capability for not supporting overprovisioning.
Risk Level: Low
Testing: N/A
Docs Changes: Included in PR
Release Notes: N/A
This should eliminate the need for #8093. And we can remove the
disable_overprovisioningflag added in #8080, since it never got used. (I can add that to this PR if you'd like.)@htuch @alyssawilk @snowp